Merge pull request #2326 from DARMA-tasking/2319-fix-makelb-undefined…

…-reference #2319: fix undefined reference to `makeLB` in collection_extended
DARMA-tasking · Jul 17, 2024 · 0360247 · 0360247
2 parents 0a89430 + c18c85c
commit 0360247
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 14 deletions.
diff --git a/src/vt/vrt/collection/balance/lb_invoke/lb_manager.cc b/src/vt/vrt/collection/balance/lb_invoke/lb_manager.cc
@@ -173,19 +173,6 @@ void LBManager::setLoadModel(std::shared_ptr<LoadModel> model) {
                    nlb_data->getUserData());
 }
 
-template <typename LB>
-LBManager::LBProxyType
-LBManager::makeLB(std::string const& lb_name) {
-  auto proxy = theObjGroup()->makeCollective<LB>(lb_name);
-  auto strat = proxy.get();
-  strat->init(proxy);
-  auto base_proxy = proxy.template castToBase<lb::BaseLB>();
-
-  destroy_lb_ = [proxy]{ proxy.destroyCollective(); };
-
-  return base_proxy;
-}
-
 void LBManager::defaultPostLBWork(ReassignmentMsg* msg) {
   auto reassignment = msg->reassignment;
   auto phase = msg->phase;

diff --git a/src/vt/vrt/collection/balance/lb_invoke/lb_manager.h b/src/vt/vrt/collection/balance/lb_invoke/lb_manager.h
@@ -231,7 +231,16 @@ struct LBManager : runtime::component::Component<LBManager> {
    * \return objgroup proxy to the new load balancer
    */
   template <typename LB>
-  LBProxyType makeLB(std::string const& lb_name = {});
+  LBProxyType makeLB(std::string const& lb_name = {}) {
+    auto proxy = theObjGroup()->makeCollective<LB>(lb_name);
+    auto strat = proxy.get();
+    strat->init(proxy);
+    auto base_proxy = proxy.template castToBase<lb::BaseLB>();
+
+    destroy_lb_ = [proxy]{ proxy.destroyCollective(); };
+
+    return base_proxy;
+  }
 
 protected:
   /**