Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake dependency on Kokkos Kernels needs to be updated #263

Closed
PhilMiller opened this issue Sep 1, 2022 · 3 comments · Fixed by #290
Closed

CMake dependency on Kokkos Kernels needs to be updated #263

PhilMiller opened this issue Sep 1, 2022 · 3 comments · Fixed by #290
Assignees

Comments

@PhilMiller
Copy link
Member

When building EMPIRE against newer Trilinos with Kokkos 3.7, I get the following warning:

CMake Warning (dev) at TPL/checkpoint/src/CMakeLists.txt:86 (target_link_libraries):
  The library that is being linked to, kokkoskernels, is marked as being
  deprecated by the owner.  The message provided by the developer is:

  WARNING: The non-namespaced target 'kokkoskernels' is deprecated! If always
  using newer versions of the project 'Trilinos', then use the new namespaced
  target 'KokkosKernels::kokkoskernels', or better yet,
  'KokkosKernels::all_libs' to be less sensitive to changes in the definition
  of targets in the package 'KokkosKernels'.  Or, to maintain compatibility
  with older or newer versions the project 'Trilinos', instead link against
  the libraries specified by the variable 'KokkosKernels_LIBRARIES'.
@PhilMiller
Copy link
Member Author

Per discussion with the Kokkos folks, there's currently no way to work around this that will suit both stand-alone and Trilinos-embedded Kokkos Kernels. Hopefully a fix will make it into Kokkos Kernels 4.0.1

@PhilMiller
Copy link
Member Author

Can fix after kokkos/kokkos-kernels#1749 makes its way into Trilinos and downstream

PhilMiller added a commit that referenced this issue Jul 4, 2023
PhilMiller added a commit that referenced this issue Jul 5, 2023
PhilMiller added a commit that referenced this issue Jul 13, 2023
lifflander pushed a commit that referenced this issue Jul 13, 2023
lifflander added a commit that referenced this issue Jul 14, 2023
#263: Use either `Kokkos::` or `KokkosKernels::` `EXPORT` namespace for linking against Kokkos Kernels
@PhilMiller
Copy link
Member Author

With kokkos/kokkoskernels#2020 merged and now released in Kokkos/Kernels 4.2, the workaround may no longer be necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant