Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump version #703

Merged
merged 3 commits into from
Feb 19, 2024
Merged

Bump version #703

merged 3 commits into from
Feb 19, 2024

Conversation

skrawcz
Copy link
Collaborator

@skrawcz skrawcz commented Feb 19, 2024

A few things - see commits.

Changes

  • h_diskcache
  • h_diskcache example README
  • version

How I tested this

  • locally

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

@skrawcz
Gates debug log for h_diskcache plugin
ce0e658 
Debug logs shouldn't be interpolated if they're not going to be used.
This could be a costly operation.

We also set a max length, since this could be a really long string if it's
dataframe, so limiting it to 200 seems reasonable for now.
@skrawcz
Updates h_diskcache README
82c85bb 
It had some typos, and otherwise needed a little more
explanation of what this adapter is doing.
@skrawcz
Bumps version to 1.50.0
a864342 
To push out diskcache plugin.
@skrawcz skrawcz merged commit cebaf3e into main Feb 19, 2024
22 checks passed
@skrawcz skrawcz deleted the bump_version branch February 19, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elijahbenizzy elijahbenizzy elijahbenizzy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skrawcz @elijahbenizzy