Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contributing guidelines + code of conduct #292

Merged
merged 5 commits into from
Jan 30, 2022
Merged

Conversation

elsehow
Copy link
Contributor

@elsehow elsehow commented Jan 30, 2022

let's check this first, and I'll add it to the other repos once we're satisfied.

@elsehow elsehow requested a review from JakeHartnell January 30, 2022 21:06
@vercel
Copy link

vercel bot commented Jan 30, 2022

@elsehow is attempting to deploy a commit to the DAO DAO Team on Vercel.

To accomplish this, @elsehow needs to request access to the Team.

Afterwards, an owner of the Team is required to accept their membership request.

If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account.

@JakeHartnell
Copy link
Member

Do we need to add that all contributions will fall under the open source license or is that just assumed?

Copy link
Member

@JakeHartnell JakeHartnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a few comments, but LGTM.

@JakeHartnell
Copy link
Member

It's also complaining about prettier...

elsehow and others added 4 commits January 30, 2022 14:09
Co-authored-by: Jake Hartnell <Jake.Hartnell@gmail.com>
Co-authored-by: Jake Hartnell <Jake.Hartnell@gmail.com>
@JakeHartnell
Copy link
Member

Looks good. Let's add this to dao-contracts as well. 🙏

@JakeHartnell JakeHartnell merged commit a2954d5 into main Jan 30, 2022
@JakeHartnell JakeHartnell deleted the nick/code-of-conduct branch January 30, 2022 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants