Fix voting module native token proposal deposit on instantiate #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoahSaso
force-pushed
the
noah/fix-native-voting-module-prop-deposit-init
branch
from
fec882d to
1474cd7
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## development #786 +/- ##
==============================================
Coverage ? 96.69%
==============================================
Files ? 204
Lines ? 52651
Branches ? 0
==============================================
Hits ? 50913
Misses ? 1738
Partials ? 0 ☔ View full report in Codecov by Sentry. |
NoahSaso
force-pushed
the
noah/fix-native-voting-module-prop-deposit-init
branch
2 times, most recently
from
49a6916 to
d18b04d
Compare
…uring instantiation.
NoahSaso
force-pushed
the
noah/fix-native-voting-module-prop-deposit-init
branch
from
d18b04d to
537c2c6
Compare
JakeHartnell
approved these changes
Dec 18, 2023
NoahSaso
force-pushed
the
noah/fix-native-voting-module-prop-deposit-init
branch
from
e063c47 to
9a50f20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #765
This allows setting up a proposal deposit using the newly created voting module token on DAO instantiation.