Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final CW4 cleanup #723

Merged
merged 3 commits into from
Aug 2, 2023
Merged

Final CW4 cleanup #723

merged 3 commits into from
Aug 2, 2023

Conversation

NoahSaso
Copy link
Member

The other cw4 cleanup PR (#691) was merged a bit too early. It was missing a contract validation and left the unused state variables in. This PR makes these changes.

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (29bea8d) 93.97% compared to head (b33b6ee) 93.98%.

Additional details and impacted files
@@             Coverage Diff              @@
##           development     #723   +/-   ##
============================================
  Coverage        93.97%   93.98%           
============================================
  Files               62       62           
  Lines             5596     5600    +4     
============================================
+ Hits              5259     5263    +4     
  Misses             337      337           
Files Changed Coverage Δ
contracts/voting/dao-voting-cw4/src/contract.rs 94.44% <100.00%> (+0.25%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JakeHartnell JakeHartnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few linting fixups.

@JakeHartnell
Copy link
Member

Closes #711.

Copy link
Collaborator

@bekauz bekauz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@NoahSaso NoahSaso merged commit ec13a79 into development Aug 2, 2023
@NoahSaso NoahSaso deleted the noah/clean-cw4 branch August 2, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants