External staking rewards #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xekez
reviewed
Feb 24, 2022
There was a problem hiding this comment.
Just an initial pass. I'll take another more detailed look soon. Unsure about the logic around multiple fund messages being executed. Could well be correct.
Previously the idea was to have two staking rewards contracts. This seems to handle both cw20 tokens and native tokens. Should we close open PRs for those other contracts?
ben2x4
force-pushed
the
staking-contract-hooks
branch
from
316018b to
6b3ed8e
Compare
Callum-A
previously approved these changes
Mar 23, 2022
0xekez
reviewed
Mar 24, 2022
0xekez
previously approved these changes
Apr 11, 2022
|
@ben2x4, let's clean up the unused variable linting errors and merge. 🚀 |
JakeHartnell
previously approved these changes
Apr 13, 2022
ben2x4
force-pushed
the
external-staking-rewards
branch
from
ffe8ed9 to
3caf09e
Compare
0xekez
approved these changes
Apr 14, 2022
JakeHartnell
approved these changes
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP in progress but wanted to get some feed back if possible cc @verminator23