Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add start_height field to proposal queries #165

Merged
merged 1 commit into from
Feb 4, 2022

Conversation

0xekez
Copy link
Contributor

@0xekez 0xekez commented Feb 3, 2022

The amount of voting power a given address has in a proposal is determined by their voting power on the block when the proposal as started. We currently do not expose this information via proposal queries which makes it quite the detective operation to determine if a given address can vote in a proposal.

Copy link
Contributor

@ben2x4 ben2x4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though would love someone a little more familiar with this contract to review.

Copy link
Contributor

@maurolacy maurolacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@JakeHartnell JakeHartnell merged commit 67c3f0c into main Feb 4, 2022
@JakeHartnell JakeHartnell deleted the zeke/proposal-height branch February 4, 2022 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants