-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow admin to update unstaking duration for stake cw20 #142
Conversation
Looks great! Just needs some basic tests:
|
@JakeHartnell Tests are added |
sorry, this sucks, but significant changes were made to the staking contract while this was in flight. Let me know if you have any issues/questions with resolving conflicts here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge conflicts, might be a doozy
No worries. Fixed the conflicts. Making one more change though: consolidating GetConfig and UnstakingDuration queries |
Hmmmm, build errors, maybe we just delete Will merge when fixed. Let's ship it. |
Looks like the uint dependency is causing it to fail Here's the output from the build pipeline:
|
One of our dependencies (uint) requires rust nightly. Updated the Github actions config to use the nightly toolchain |
why did this PR introduce this dependency? |
I think it's upstream in one of our deps. FWIW, also works in the latest |
This PR allows the unstaking period to be changed in stake-cw20 and stake-cw20-gov. Addresses Issue #98