Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow admin to update unstaking duration for stake cw20 #142

Merged
merged 16 commits into from
Jan 28, 2022

Conversation

vernonjohnson
Copy link
Contributor

@vernonjohnson vernonjohnson commented Jan 22, 2022

This PR allows the unstaking period to be changed in stake-cw20 and stake-cw20-gov. Addresses Issue #98

@JakeHartnell
Copy link
Member

Looks great! Just needs some basic tests:

  • Config can be updated
  • Config can only be updated by admin

@vernonjohnson
Copy link
Contributor Author

@JakeHartnell Tests are added

@ben2x4
Copy link
Contributor

ben2x4 commented Jan 28, 2022

sorry, this sucks, but significant changes were made to the staking contract while this was in flight. Let me know if you have any issues/questions with resolving conflicts here.

Copy link
Contributor

@ben2x4 ben2x4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge conflicts, might be a doozy

@vernonjohnson
Copy link
Contributor Author

vernonjohnson commented Jan 28, 2022

sorry, this sucks, but significant changes were made to the staking contract while this was in flight. Let me know if you have any issues/questions with resolving conflicts here.

No worries. Fixed the conflicts. Making one more change though: consolidating GetConfig and UnstakingDuration queries

@JakeHartnell
Copy link
Member

Hmmmm, build errors, maybe we just delete Cargo.lock and re-build?

Will merge when fixed. Let's ship it. :shipit:

@vernonjohnson
Copy link
Contributor Author

Looks like the uint dependency is causing it to fail

Here's the output from the build pipeline:

error: edition 2021 is unstable and only available with -Z unstable-options.
Error: edition 2021 is unstable and only available with -Z unstable-options.
error: could not compile `uint`
Error: could not compile `uint`
To learn more, run the command again with --verbose.
warning: build failed, waiting for other jobs to finish...
Warning: error: build failed
Error: The process '/home/runner/.cargo/bin/cargo' failed with exit code 101

@vernonjohnson
Copy link
Contributor Author

One of our dependencies (uint) requires rust nightly. Updated the Github actions config to use the nightly toolchain

@ben2x4
Copy link
Contributor

ben2x4 commented Jan 28, 2022

One of our dependencies (uint) requires rust nightly. Updated the Github actions config to use the nightly toolchain

why did this PR introduce this dependency?

@JakeHartnell JakeHartnell merged commit 3c3e178 into main Jan 28, 2022
@JakeHartnell
Copy link
Member

One of our dependencies (uint) requires rust nightly. Updated the Github actions config to use the nightly toolchain

why did this PR introduce this dependency?

I think it's upstream in one of our deps. FWIW, also works in the latest stable release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants