Add proposer field to Proposal

[Callum-A]

Addresses #136

Adds proposer field to the Proposal which is populated by the sender of the propose message. Noticed the CW3 ProposalResponse struct does not have a proposer field. Does this need to be addressed separately?

[0xekez]

Thanks for the contribution! Would you mind adding a test for this creating a new proposal and verifying that the field is set?

[Callum-A]

Thanks for the contribution! Would you mind adding a test for this creating a new proposal and verifying that the field is set?

Will do, should I just add this under test_propose_works in tests.rs?

[0xekez]

Wherever is you think makes the most sense. Feel free to add a new test as well. Can never have too many :)

[Callum-A]

Will do. Any guidance on how to achieve this? As the CW3 Proposal Response message does not feature a proposer field. And the execute response already has an attribute for sender which is effectively the same as the proposer.

[0xekez]

I've got no problem with making our own proposal response type that's the same as the cw3 version modulo the proposer field. You probably want to add it in query.rs.

When parsing, JSON doesn't even care if you have extra fields most of the time so it shouldn't be an issue in most cases to have the extra field for folks who expect us to implement cw3. Others welcome to chime in and disagree.

[Callum-A]

I've got no problem with making our own proposal response type that's the same as the cw3 version modulo the proposer field. You probably want to add it in query.rs.

When parsing, JSON doesn't even care if you have extra fields most of the time so it shouldn't be an issue in most cases to have the extra field for folks who expect us to implement cw3. Others welcome to chime in and disagree.

Decided to go with this, implemented the same attrs as the base CW3 module + proposer. Open to any feedback / disagreements.

[0xekez]

Screenshot of the UI showing the proposer on a multisig based on this PR.

[0xekez]

This is great. Thanks so much for pushing this through! Comments are lovely, test is lovely, and schema is regenerated.

[0xekez]

UI update for this: DA0-DA0/dao-dao-ui#255

[JakeHartnell]

🎉

Congrats @Callum-A on your first DAO DAO contribution!