Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Det() returns zero for the sigular matrix #530

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Conversation

IvanaGyro
Copy link
Collaborator

According to cuSOLVER's document, returned devInfo greater than zero means U[devInfo - 1, devInfo - 1] (zero-indexed) is zero, which implies the determinant is zero.

According to cuSOLVER's document, returned `devInfo` greater than zero
means U[devInfo - 1, devInfo - 1] (zero-indexed) is zero, which implies
the determinant is zero.
@IvanaGyro IvanaGyro added the bug Something isn't working label Dec 4, 2024
@IvanaGyro
Copy link
Collaborator Author

Link to the document: https://docs.nvidia.com/cuda/cusolver/index.html#cusolverdn-t-getrf

If LU factorization failed, i.e. matrix A (U) is singular, The output parameter devInfo=i indicates U(i,i) = 0.
If output parameter devInfo = -i (less than zero), the i-th parameter is wrong (not counting handle).

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.58%. Comparing base (672b7e9) to head (eb67ff2).
Report is 3 commits behind head on dev-master.

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-master     #530   +/-   ##
===========================================
  Coverage       17.58%   17.58%           
===========================================
  Files             211      211           
  Lines           44733    44733           
  Branches        14941    14941           
===========================================
  Hits             7868     7868           
  Misses          32751    32751           
  Partials         4114     4114           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IvanaGyro IvanaGyro merged commit 32f2ef7 into dev-master Dec 5, 2024
4 checks passed
@IvanaGyro IvanaGyro deleted the return-zero-det branch December 5, 2024 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants