Uniform randomizing function respects given range #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C's complex numbers, C++'s complex numbers and CUDA's complex numbers have the same memory layout. It's safe to access the memory via the pointer of `std::complex` if the memory block can be access by the CPU.
This change fixes the problem that the uniform random number generator ignores the given lower bound and higher bound when the view types (Storage, Tensor, and UniTensor) are assigned on the GPU.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-master #529 +/- ##
==============================================
+ Coverage 17.58% 17.63% +0.04%
==============================================
Files 211 211
Lines 44733 44749 +16
Branches 14941 14950 +9
==============================================
+ Hits 7868 7893 +25
+ Misses 32751 32734 -17
- Partials 4114 4122 +8 ☔ View full report in Codecov by Sentry. |
yingjerkao
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the problem that the uniform random number generator ignores the given lower bound and higher bound when the view types (Storage, Tensor, and UniTensor) are assigned on the GPU.