Refactor: Templatise Movemem() function
#504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-master #504 +/- ##
==============================================
- Coverage 16.78% 16.75% -0.03%
==============================================
Files 221 221
Lines 53173 52870 -303
Branches 19822 19707 -115
==============================================
- Hits 8923 8859 -64
+ Misses 39940 39715 -225
+ Partials 4310 4296 -14 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
This was referenced Nov 10, 2024
Merged
This is the preparation for refactoring the `Storage` class.
IvanaGyro
force-pushed
the
templatise_functions
branch
from
4026a23 to
83b07ca
Compare
kaihsin
approved these changes
Nov 19, 2024
yingjerkao
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a task listed in #500.
The
Movemem_cpu()function has two versions of implementation. One is for integral types, the other is for the other types. Two versions may be combined into one. However, this PR only templatises them and doesn't dip into the implementations.This PR doesn't break any test for both CPU and GPU.