Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip test cases testing unimplemented functions #503

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

IvanaGyro
Copy link
Collaborator

Some functions is not implemented in CUDA.

The test cases below are skipped:

  • Arnoldi.gpu_k_max
  • Arnoldi.gpu_k1_test
  • Arnoldi.gpu_mat_type_real_test
  • Arnoldi.gpu_smallest_dim
  • Arnoldi.gpu_which_LM_test
  • Arnoldi.gpu_which_LR_test
  • Arnoldi.gpu_which_LI_test
  • Arnoldi.gpu_which_SM_test
  • Arnoldi.gpu_which_SR_test
  • Arnoldi.gpu_which_SI_test
  • BlockUniTensorTest.gpu_Trace
  • DenseUniTensorTest.gpu_Trace
  • ExpM.gpu_ExpM_test

Some functions is not implemented in CUDA.

The test cases below are skipped:
- Arnoldi.gpu_k_max
- Arnoldi.gpu_k1_test
- Arnoldi.gpu_mat_type_real_test
- Arnoldi.gpu_smallest_dim
- Arnoldi.gpu_which_LM_test
- Arnoldi.gpu_which_LR_test
- Arnoldi.gpu_which_LI_test
- Arnoldi.gpu_which_SM_test
- Arnoldi.gpu_which_SR_test
- Arnoldi.gpu_which_SI_test
- BlockUniTensorTest.gpu_Trace
- DenseUniTensorTest.gpu_Trace
- ExpM.gpu_ExpM_test
Copy link

codecov bot commented Nov 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.78%. Comparing base (72453ca) to head (21d901b).
Report is 37 commits behind head on dev-master.

Additional details and impacted files
@@              Coverage Diff               @@
##           dev-master     #503      +/-   ##
==============================================
+ Coverage       16.60%   16.78%   +0.17%     
==============================================
  Files             221      221              
  Lines           48490    53173    +4683     
  Branches        20272    19822     -450     
==============================================
+ Hits             8053     8923     +870     
- Misses          36143    39940    +3797     
- Partials         4294     4310      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@manuschneider
Copy link
Collaborator

Are these functions not available independently of whether cutensor and/or cuquantum are available?

I ran the tests with the following options:

DUSE_CUDA=ON
DUSE_CUTENSOR=OFF
DUSE_CUQUANTUM=OFF

and got the result:

The following tests did not run:
	659 - BlockUniTensorTest.gpu_Trace (Skipped)
	712 - DenseUniTensorTest.gpu_Trace (Skipped)
	791 - ExpM.gpu_ExpM_test (Skipped)
	794 - Arnoldi.gpu_which_LM_test (Skipped)
	795 - Arnoldi.gpu_which_LR_test (Skipped)
	796 - Arnoldi.gpu_which_LI_test (Skipped)
	797 - Arnoldi.gpu_which_SM_test (Skipped)
	798 - Arnoldi.gpu_which_SR_test (Skipped)
	799 - Arnoldi.gpu_which_SI_test (Skipped)
	800 - Arnoldi.gpu_mat_type_real_test (Skipped)
	801 - Arnoldi.gpu_k1_test (Skipped)
	802 - Arnoldi.gpu_k_max (Skipped)
	803 - Arnoldi.gpu_smallest_dim (Skipped)

The following tests FAILED:
	793 - Lanczos_Gnd.gpu_Bk_Lanczos_Gnd_test (Failed)
	815 - Svd.gpu_U1_zeros_test (Failed)
	837 - linalg_Test.gpu_BkUt_Svd_truncate3 (Failed)
	838 - linalg_Test.gpu_BkUt_Qr1 (Failed)
	840 - linalg_Test.gpu_BkUt_expM (Failed)

Some tests still seem to fail here, is it related to this PR?

@IvanaGyro
Copy link
Collaborator Author

IvanaGyro commented Nov 12, 2024

The failed tests you listed may be the bugs that haven't been addressed. Except 815 - Svd.gpu_U1_zeros_test, which was reported at #505. For the skipped tests, yes, they are not implemented whether cutensor and/or cuquantum are used or not.

Copy link
Collaborator

@manuschneider manuschneider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the unimplemented functions in the Cytnx Development Roadmap to keep track of it for possible future implementation. I m not sure though if it is the right place to document unsupported functions.

@manuschneider manuschneider merged commit 9f46fd4 into dev-master Nov 13, 2024
4 checks passed
@manuschneider manuschneider deleted the skip-tests branch November 13, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants