Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update, add generator on C++ side for UT #316

Merged
merged 10 commits into from
Oct 25, 2023
Merged

Conversation

kaihsin
Copy link
Member

@kaihsin kaihsin commented Oct 20, 2023

This addresses the first part of #314

Remaining todo:

  1. add random generator to UniTensor as static functions.
  2. python binding.

@kaihsin kaihsin marked this pull request as draft October 20, 2023 04:07
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #316 (df12df8) into dev-master (4d885f0) will increase coverage by 0.66%.
Report is 16 commits behind head on dev-master.
The diff coverage is 34.04%.

@@              Coverage Diff               @@
##           dev-master     #316      +/-   ##
==============================================
+ Coverage       17.13%   17.79%   +0.66%     
==============================================
  Files             220      220              
  Lines           48514    48733     +219     
  Branches        19816    19932     +116     
==============================================
+ Hits             8312     8672     +360     
+ Misses          36176    35865     -311     
- Partials         4026     4196     +170     
Files Coverage Δ
include/backend/Scalar.hpp 21.15% <100.00%> (+0.13%) ⬆️
include/random.hpp 66.66% <ø> (ø)
include/UniTensor.hpp 44.87% <80.00%> (+0.62%) ⬆️
src/linalg/Norm.cpp 35.29% <42.85%> (+13.55%) ⬆️
src/linalg/InvM_.cpp 43.24% <36.00%> (+43.24%) ⬆️
src/UniTensor.cpp 60.40% <28.57%> (-7.37%) ⬇️
src/linalg/InvM.cpp 27.65% <27.58%> (-0.12%) ⬇️
src/linalg/Eig.cpp 24.00% <26.31%> (+2.37%) ⬆️
src/linalg/Eigh.cpp 25.71% <26.31%> (+0.71%) ⬆️

... and 19 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jeffry1829 jeffry1829 marked this pull request as ready for review October 23, 2023 02:10
@hunghaoti hunghaoti mentioned this pull request Oct 24, 2023
3 tasks
@kaihsin
Copy link
Member Author

kaihsin commented Oct 24, 2023

Whats the status of this PR?

@hunghaoti
Copy link
Collaborator

Whats the status of this PR?

It has been done. I will merge it if there is no any problem.

@hunghaoti hunghaoti merged commit 551e7ee into dev-master Oct 25, 2023
4 checks passed
@hunghaoti hunghaoti deleted the khwu/UT_gen#314 branch October 25, 2023 02:33
@kaihsin
Copy link
Member Author

kaihsin commented Oct 25, 2023 via email

@hunghaoti
Copy link
Collaborator

Wait what is going on with that error

On Tue, Oct 24, 2023, 22:33 hunghaoti @.> wrote: Merged #316 <#316> into dev-master. — Reply to this email directly, view it on GitHub <#316 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFCX3SJZGLM2LK46Q66RJRLYBB3BDAVCNFSM6AAAAAA6IJC5UWVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJQG43DCNBSGE3DIMY . You are receiving this because you authored the thread.Message ID: @.>

All of the tests have been passed (see https://github.com/Cytnx-dev/Cytnx/actions/runs/6634802398/job/18024752490). Which error are you mention about ? Is the error occurs about 10 hours ago ? If it is, that error occurs in the process "Upload coverage to Codecov" after all unit test passed. It may caused by the server error for codecov. I just rerun the workflow again and there is no problem.

@hunghaoti
Copy link
Collaborator

Sorry I cannot see the content of this link "https://github.com/notifications/unsubscribe-auth/AFCX3SJZGLM2LK46Q66RJRLYBB3BDAVCNFSM6AAAAAA6IJC5UWVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJQG43DCNBSGE3DIMY". it says that "That unsubscribe link isn't valid for your account. "

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants