Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced-foundry: DAO - video 6 | adding note for changed admin role; missing semicolon; #373

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

MrRobWeb
Copy link
Contributor

Advanced-foundry: DAO - video 6

adding note for changed admin role

  • TimelockController: Changed the role architecture to use DEFAULT_ADMIN_ROLE as the admin for all roles, instead of the bespoke TIMELOCK_ADMIN_ROLE that was used previously. This aligns with the general recommendation for AccessControl and makes the addition of new roles easier. Accordingly, the admin parameter and timelock will now be granted DEFAULT_ADMIN_ROLE instead of TIMELOCK_ADMIN_ROLE. (#3799)

missing semicolon

@EngrPips
Copy link
Contributor

Hello @MrRobWeb, Thanks for the contribution. This will be attended to appropriately as soon as possible.

@Equious Equious changed the base branch from main to dev February 26, 2025 16:19
@Equious
Copy link
Contributor

Equious commented Feb 26, 2025

@EngrPips Can you make sure this gets a mention in the chronological updates for me, please?

@Equious Equious merged commit 445fa6c into Cyfrin:dev Feb 26, 2025
@EngrPips
Copy link
Contributor

Screenshot 2025-02-26 at 17 26 11

It has been mentioned sir @Equious

@MrRobWeb MrRobWeb deleted the foundry-advanced-dao-video-6 branch February 27, 2025 09:13
@MrRobWeb
Copy link
Contributor Author

Screenshot 2025-02-26 at 17 26 11

It has been mentioned sir @Equious

Hi @Equious, Hi @EngrPips ,
by the way, where can I find the chronological updates?

@EngrPips
Copy link
Contributor

Here https://github.com/Cyfrin/foundry-full-course-cu/blob/main/chronological-updates.md sir @MrRobWeb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants