Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: conditional warning if no root dependencies were found #398

Merged
merged 7 commits into from
Jun 28, 2023

Conversation

jkowalleck
Copy link
Member

@jkowalleck jkowalleck commented Jun 28, 2023

the warning was shown when all was correct,
but was omitted when it should have been shown ...

@jkowalleck jkowalleck added the bug Something isn't working label Jun 28, 2023
@jkowalleck jkowalleck requested a review from a team as a code owner June 28, 2023 14:12
cyclonedx/model/bom.py Outdated Show resolved Hide resolved
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck force-pushed the fix-missing-reps-warning branch from c141d97 to 459d324 Compare June 28, 2023 15:08
tests/test_output_xml.py Outdated Show resolved Hide resolved
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck changed the title fix: conditional warning if no direct dependencies were found fix: conditional warning if no root dependencies were found Jun 28, 2023
@jkowalleck
Copy link
Member Author

@ptdropper FYI
this fix should remove the unexpected warning you saw lately.

@jkowalleck jkowalleck merged commit c8175bb into main Jun 28, 2023
@jkowalleck jkowalleck deleted the fix-missing-reps-warning branch June 28, 2023 15:24
@schlenk
Copy link
Contributor

schlenk commented Jun 28, 2023

This fixes #367

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants