fix: multiple hashes being created for an externalRefernce which is n…

…ot as required Signed-off-by: Paul Horton <phorton@sonatype.com>
CycloneDX · Oct 12, 2021 · 970d192 · 970d192
1 parent 7a49f9d
commit 970d192
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/cyclonedx/model/__init__.py b/cyclonedx/model/__init__.py
@@ -150,11 +150,14 @@ class ExternalReference:
     _hashes: List[HashType] = []
 
     def __init__(self, reference_type: ExternalReferenceType, url: str, comment: str = None,
-                 hashes: List[HashType] = []):
+                 hashes: List[HashType] = None):
         self._reference_type = reference_type
         self._url = url
         self._comment = comment
-        self._hashes = hashes
+        if not hashes:
+            self._hashes.clear()
+        else:
+            self._hashes = hashes
 
     def add_hash(self, our_hash: HashType):
         """

diff --git a/tests/test_parser_pipenv.py b/tests/test_parser_pipenv.py
@@ -34,3 +34,4 @@ def test_simple(self):
         self.assertEqual('toml', components[0].get_name())
         self.assertEqual('0.10.2', components[0].get_version())
         self.assertEqual(len(components[0].get_external_references()), 2)
+        self.assertEqual(len(components[0].get_external_references()[0].get_hashes()), 1)