V3.3 #36
Merged
V3.3 #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add publish docker image workflow
The sockets extension is required by the current composer.lock.
Fixes:
Your lock file does not contain a compatible set of packages. Please run composer update.
Problem 1
- chrome-php/wrench is locked to version v1.6.0 and an update of this package was not requested.
- chrome-php/wrench v1.6.0 requires ext-sockets * -> it is missing from your system. Install or enable PHP's sockets extension.
Problem 2
- chrome-php/chrome is locked to version v1.11.0 and an update of this package was not requested.
- chrome-php/chrome v1.11.0 requires chrome-php/wrench ^1.6 -> satisfiable by chrome-php/wrench[v1.6.0].
- chrome-php/wrench v1.6.0 requires ext-sockets * -> it is missing from your system. Install or enable PHP's sockets extension.
Signed-off-by: Raphaël Mélotte <raphael.melotte@mind.be>
composer was so far missing from the Docker image, so it could not be used to install the dependencies. Install it and move it to a directory already in PATH, so that we can later run "composer install". Signed-off-by: Raphaël Mélotte <raphael.melotte@mind.be>
Without running composer install before running, the application encounters the following error: discount-bandit-discount-bandit-1 | Fatal error: Uncaught Error: Failed opening required '/app/vendor/autoload.php' (include_path='.:/usr/local/lib/php') in /app/artisan:9 Note that here, running 'composer install' is added to the entrypoint and not the Dockerfile because it seems to require the SQLite database file to exist already at that time (at the database is only created at runtime): SQLSTATE[HY000] [14] unable to open database file (Connection: sqlite, SQL: PRAGMA foreign_keys = ON;) Signed-off-by: Raphaël Mélotte <raphael.melotte@mind.be>
When mounting the database.sqlite file while it does not exist, docker creates instead a new folder called 'database.sqlite'. To fix it, mount the database folder instead, so that the application can generate the 'database.sqlite' file in the '/app/database' folder. Note that the '.env' file has a similar problem, which cannot be fixed in the same way (because we would have to mount the entire top-level folder as a volume). Signed-off-by: Raphaël Mélotte <raphael.melotte@mind.be>
Currently if docker-compose is run before a .env file is created, a folder will be created instead which leads to confusion about what should be done. Since we don't have a fix for it yet, just document in the README file that the .env file should be created first. While at it, also mention the APP_KEY which is also mandatory. Signed-off-by: Raphaël Mélotte <raphael.melotte@mind.be>
The octane and supervisord logs provide useful information that is otherwise not available using "docker logs". To still make it possible for users to read those logs from the host, place them in a separate '/logs/' directory that gets mounted as a volume. Signed-off-by: Raphaël Mélotte <raphael.melotte@mind.be>
This fixes the following error: call_user_func(): Argument #1 ($callback) must be a valid callback, class App\\Helpers\\URLHelper does not have a method \"get_mediamarkt_key\" at /app/app/Helpers/URLHelper.php:64) Signed-off-by: Raphaël Mélotte <raphael.melotte@mind.be>
In the case of Mediamarkt es there is only one offer instead of an array. Signed-off-by: Raphaël Mélotte <raphael.melotte@mind.be>
- bump packages versions. - add product image and product link to feed. - Move the rss to notification instead of tempalte - new product list layout ( still in work) Fixes: - fix authentication not required. - add docker link to README.md - update discord link - clear cache when new store is added for a product In Progress: - walmart might not work properly as i am still working on it Took 4 hours 50 minutes
Fix Mediamarkt ES
While at it, also fix a typo in the image name. Source of the image: https://upload.wikimedia.org/wikipedia/commons/f/f0/Media_Markt_logo.svg It was manually converted using ImageMagick with the following command: convert -background none -resize 150 mediamarkt.svg mediamarkt.png Signed-off-by: Raphaël Mélotte <raphael.melotte@mind.be>
Mediamarkt.be already works using the same code as for mediamarkt.es. Signed-off-by: Raphaël Mélotte <raphael.melotte@mind.be>
Add support for mediamarkt be
- add Ajio test - add myntra test - add nykaa test - add snapdeal test - add tataCliq test Fixes: - fix amazon poland price only getting thousands. - fix single product store view. Enhancements: - add scroll to top page when page has changed. - change layout for product page. - preparing api for mobile application Took 7 hours 52 minutes
…ndencies docker-compose: install dependencies from within the container
- revert database path in docker compose - update compose install / update in docker. Took 54 minutes
Took 1 minute
Took 3 minutes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.