Bukkit PlayerMoveEvent appears to be doubled up

[StargateMC]

PlayerMoveEvent for bukkit appears to be doubled up, causing faction territory change messages to be duplicated.

This is also a bug in KCauldron.... I've looked at the source for Factions and they're doing it right... listening for the event and calling sendMessage to the player once per event.

[sameer]

What build of Thermos are you using?

[sameer]

And it is strange...I do not see the doubling of events on my factions server. They only receive the message of moving to another block of land once.

[StargateMC]

22, your latest one

Sent from my iPhone

On 13 Feb 2016, at 1:09 AM, Sam notifications@github.com wrote:

What build of Thermos are you using?

—
Reply to this email directly or view it on GitHub.

[sameer]

So it happens for both Thermos and KCauldron?

[ghost]

Can confirm this. Happens on dimension change as well.

[StargateMC]

Yep

Sent from my iPhone

On 13 Feb 2016, at 2:36 AM, Sam notifications@github.com wrote:

So it happens for both Thermos and KCauldron?

—
Reply to this email directly or view it on GitHub.

[Bogdan-G]

It may increase the amount of data, so changes are such as this.

[StargateMC]

What do you mean?

[sameer]

@Bogdan-G I bumped the delta so there would be fewer move events.

[Bogdan-G]

@DraksterAU more mods, more traffics, more pool size packet.

[StargateMC]

Hi @robotia

Can you respond when you've released this for me to test ? :)

[StargateMC]

@robotia B24 didn't fix this one :( sadface.

[sameer]

How are you seeing the event doubled up?

[StargateMC]

Factions/WorldGuard/Towny use the PlayerMoveEvent to detect chunk changes and therefore territory changes.
Every time territory changes in any of these plugins the messages are duplicated.

I've looked at the source for Factions and can see it only fires 1 change message per PlayerMoveEvent that results in a chunk+Territory change.

[sameer]

@DraksterAU I believe this is an issue unique to you. On my Tekkit Legends server running B23 with Factions, I have never had this problem. 0.o

[StargateMC]

@robotia on both the post here and with the KCauldron Devs I have people confirming they also have the issue.

I've also tried running JUST Factions with thermos and KCauldron and the issue persists.

[StargateMC]

What version of thermos + factions are you running?

[ghost]

I believe this is an issue unique to you. On my Tekkit Legends server running B23?

[StargateMC]

@Cracks777 your not making sense...

[sameer]

Copy + paste master
Let me check on my server quick, I'll get a screenshot

[StargateMC]

@Cracks777 the more important half of that is his version of factions.

[ghost]

lol just trying to help.

[StargateMC]

@Cracks777 PS I have tried B23 with @robotia's factions build under fixes here on both a Linux and Windows machine with Java 8 and issue persists.

[sameer]

Nevermind, you were right @DraksterAU somehow I missed it.

[StargateMC]

Lol @robotia no worries. Just fending off the others so the issue doesn't get closed prematurely lol

[StargateMC]

Hi @robotia I tested... doesn't fix :(

[Time6628]

Can confirm this issue still persists. Also, it appears the second message is sent a bit late. For example, if you /f claim auto: http://prntscr.com/adbcry, you can see it claims the chunk but then also tells you that you already have the chunk. There is a slight delay after the first message, not sure if that helps or not 😸

[StargateMC]

@Time6628 markehme and I have developed work arounds For v2.8.5 of Factions.

Install the plugin here to resolve the issues;
https://github.com/MarkehMe/MassiveCoreForgeFixes

[Time6628]

@DraksterAU I have that plugin installed and the messages still appear. 🐱

[StargateMC]

@Time6628 Please post what version of Thermos, Factions, Massivecore and MassiveCoreForgeFixes you are using?

If there is a bug I'm happy to look into it and update the plugin, but the official 2.8.5 runs fine on my server with MCFF v1.1.0.

If the Fixes plugin fails, try downloading the below and using those;
https://github.com/StargateMC/Server/blob/master/base/plugins/factions.jar?raw=true
https://github.com/StargateMC/Server/blob/master/base/plugins/massivecore.jar?raw=true

[Time6628]

I am using 2.8.7Beta.

[StargateMC]

@Time6628 I wouldn't use that with cauldron - and the fixes plugin is only tested with 2.8.6 and below.

2.8.7 is for 1.9

[sameer]

Fixed in B47.