Skip to content
This repository has been archived by the owner on Jan 26, 2019. It is now read-only.

[Mod Incompatibility] Inventory Clear on Respawn with keepInventory True #236

Closed
Eufranio opened this issue Mar 13, 2016 · 34 comments
Closed

Comments

@Eufranio
Copy link

Server Log: (Use Pastebin or Github Gist)
Are no logs for this, on client and the server.

Explanation of issue:
I have keepInventory true on my server, but i'm having an problem with him today. When an player dead, your inventory don't clear. But when he click on "Respawn" button after death, your inventory is cleaned. No logs, only the error. This happened after i update to the Thermos 1614.46.

Thermos Version:
1.7.10-1614.46

@sameer
Copy link
Member

sameer commented Mar 13, 2016

O.o will investigate

@sameer
Copy link
Member

sameer commented Mar 14, 2016

One of the users on Discord tested this and found that this is not the case. Are you certain you were not using an outdated version or that this is a mistake on your part?

@djoveryde
Copy link

I've tested and inventory is kept fine on the overworld after typing the keepInventory true.

However @Eufranio double check this player is not dying in other worlds as you have to set keepInventory to true on each world by going to that world and issuing the command.

@robotia I thought at one point keepInventory defaulted to all worlds? Could be wrong.
Perhaps is there a way to add a "/Gamerule keepInventoryAll" so it flags to keep inventory on all worlds for those that want inventory kept globally?

@sameer
Copy link
Member

sameer commented Mar 14, 2016

That's definitely doable but I'd rather add it as a cauldron configuration, if it were a game rule, few people would actually know such a feature exists

@Eufranio
Copy link
Author

The players are not losing your inventories, by default. When they dead, your hotbar still with the items (the items aren't dropped). The problem is when they click on "Respawn" button, your items now are cleaned... I'm using latest stable version from Thermos, and this issue is happening after update.

@sameer
Copy link
Member

sameer commented Mar 14, 2016

@Eufranio I'm thinking this is caused by one of your modpacks...what packs do you have?

@Eufranio
Copy link
Author

I have an pack that myself created. I'm not thinking that is about the pack, because i never had this problem, happened just when i updated thermos for the latest version.

@sameer
Copy link
Member

sameer commented Mar 14, 2016

@Eufranio You have keepInventory enabled on every world as @djoveryde mentioned, correct?
Also, could you try this on a test server with most of the mods from your pack removed? Since I have reports from 2 people on Discord now that this is not happening for them, I want to determine if it is a mod-specific incompatibility

@Eufranio
Copy link
Author

Yep, i have keepInventory true on all worlds. And i tested without mods, seems fine. Maybe could be an mod incompatibility, i'll test with some mods now.

@sameer
Copy link
Member

sameer commented Mar 14, 2016

@Eufranio thank you 😄

@sameer sameer changed the title Players cleaning your inventory after respawn [Mod Incompatibility] Inventory Clear on Respawn with keepInventory True Mar 14, 2016
@Eufranio
Copy link
Author

I really don't know what mod is causing the issue... The only mod that change player inventories after death is OpenBlocks, but it's not even spawning the gravestone...

@sameer
Copy link
Member

sameer commented Mar 14, 2016

@Eufranio when players die, do they respawn in a different dimension?

@Eufranio
Copy link
Author

Yep, they spawn on server hub.

@djoveryde
Copy link

@Eufranio Do you have Multiverse plugin loaded on that server at all?

@Eufranio
Copy link
Author

No, i'm using multiworld (that plugin add dimensions).

@sameer
Copy link
Member

sameer commented Mar 15, 2016

Issue likely deals with the calling of dimension change and respawn events.

@Eufranio
Copy link
Author

I tested now, and when player death on another dimension (excluding overworld), then gravestone spawns with your inventory. But when they dead on overworld, the grave dont spawn and player lose your items.

@sameer
Copy link
Member

sameer commented Mar 15, 2016

@Eufranio the respawn and dimension events are out of order then, fixing now.

sameer pushed a commit that referenced this issue Mar 15, 2016
@Bogdan-G
Copy link

mod AoA work breaks keepInventory, Xolova wontfix it.

@Eufranio
Copy link
Author

I'm not using AoA.

@Eufranio
Copy link
Author

Tested with latest build, still bugging. (clear after click on respawn)

@Eufranio Eufranio reopened this Mar 15, 2016
@djoveryde
Copy link

What plugins/Mods do you have, its odd how no one can reproduce this error. If I can have a list of all mods & plugins you have I can test this for you.

@Eufranio
Copy link
Author

My modpack is on technic: http://api.technicpack.net/modpack/magitech-server-1710
Plugins (40): Itemizer, dynmap, WorldEdit, FrameProtect, Better_AntiSpam, OpenInv, Essentials, Offline_Teleporter, LoginSecurity, ClearLag, PlugMan, DMotd, SleepPercentage, EasyBackup, CustomShutdown, WorldGuard, DKLib, ProtocolLib, MyItems, AutoSaveWorld, MultiWorld, KitAdder, PermissionsEx, BanItem, NoteBlockAPI, Whitelist, MyMenu, Vault, EssentialsSpawn, MyCommand, TitleManager, AutoIn, ChestShop, NoteBlockPlayer, ScoreboardStats, Trading, WarpPortals, Citizens, Legendchat, CommandNPC

@Eufranio
Copy link
Author

@robotia , can you public an build that keepInventory for thermos bypass forge? I think that is the unique solution...

@sameer
Copy link
Member

sameer commented Mar 15, 2016

I do not understand what you are asking for, are you saying never notify mods that a respawn event occurs?

@Eufranio
Copy link
Author

Yep. So, when an player dead, he will respawn with vanilla presets, and it's not bugging.

@sameer
Copy link
Member

sameer commented Mar 15, 2016

I can give you something specifically for that...but it will not be updated.

@Eufranio
Copy link
Author

Yes :D while using your specific version, i will try find what the causes of the problem.

@Eufranio
Copy link
Author

Unloading the multiworld dimension (Server hub) seems resolved the problem. Now keepIventory is working. I think that's an plugin incompatibility...

@djoveryde
Copy link

Similar to Multiverse issue then. What version of Multiworld are you using?
@Eufranio Try using the next version down (IE. If your using 5.2.6 try using 5.2.5).
If you are using 5.2.7 that version is for 1.8 only and would cause problems.
Some plugins end up breaking things on their latest version. So testing by downgrading usually tends to help things.

@Eufranio
Copy link
Author

I tried the three latest versions above 5.2.7 from Bukkit, and error persists. I still thinking that is an incompatibility.

@Eufranio
Copy link
Author

Sugestion: Add an option on thermos config that allow players that dead respawn on same world (overworld), not on the server real spawn.

@sameer
Copy link
Member

sameer commented Mar 16, 2016

That is caused by one of your plugins, it is not our fault.

@Bogdan-G
Copy link

Already many times made compatible with anything on the side of the cauldron for the slaves of something else.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants