Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ontology for MalwareConfigs #871

Merged
merged 4 commits into from
Aug 23, 2022
Merged

Add ontology for MalwareConfigs #871

merged 4 commits into from
Aug 23, 2022

Conversation

cccs-rs
Copy link
Contributor

@cccs-rs cccs-rs commented Aug 22, 2022

No description provided.

Copy link
Contributor

@cccs-kevin cccs-kevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplication of NetworkConnection, NetworkHTTP and NetworkDNS, but 🤷

@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2022

Codecov Report

Merging #871 (da37232) into master (ae77979) will increase coverage by 0.30%.
The diff coverage is 98.64%.

@@            Coverage Diff             @@
##           master     #871      +/-   ##
==========================================
+ Coverage   73.54%   73.85%   +0.30%     
==========================================
  Files         132      133       +1     
  Lines       12533    12678     +145     
==========================================
+ Hits         9218     9363     +145     
  Misses       3315     3315              
Impacted Files Coverage Δ
assemblyline/common/net.py 68.64% <71.42%> (-0.39%) ⬇️
assemblyline/common/net_static.py 100.00% <100.00%> (ø)
assemblyline/odm/models/ontology/ontology.py 100.00% <100.00%> (ø)
...semblyline/odm/models/ontology/results/__init__.py 100.00% <100.00%> (ø)
...line/odm/models/ontology/results/malware_config.py 100.00% <100.00%> (ø)
assemblyline/odm/randomizer.py 95.25% <0.00%> (+0.86%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cccs-rs
Copy link
Contributor Author

cccs-rs commented Aug 23, 2022

Duplication of NetworkConnection, NetworkHTTP and NetworkDNS, but 🤷

The problem with re-using the existing models (at the moment) is that the other models have more requirements than their counterparts in this model (most if not all is optional).

This could be something we could revisit in the future.

@cccs-rs cccs-rs merged commit 5e6358e into master Aug 23, 2022
@cccs-rs cccs-rs deleted the malware_config branch August 23, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants