Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt Examples sections to be multiline for mkdocs #34

Merged
merged 3 commits into from
Jul 12, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jun 20, 2023

Changes:

  • Rename Example to Examples for all Example sections. This is required for mkdocs to display multi-line examples correctly.
  • Add the >>> to each line in the Examples. It forces mkdocs to not squash examples into one line.

@ghost ghost requested review from pawtom and Adakar June 20, 2023 13:37
@ghost ghost self-assigned this Jun 20, 2023
Copy link
Contributor

@Adakar Adakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For two or more independent examples using >>> seems to be ok but for for code blocks like sections I'd prefer to see Python code blocks - that seems to be supported by mkdocs as well

@Adakar Adakar self-requested a review June 30, 2023 22:35
Copy link
Contributor

@Adakar Adakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EduardKaverinskyi and others added 3 commits July 5, 2023 12:26
Changes:
- Rename Example to Examples for all Example sections. This is required for mkdocs to display
multi-line examples correctly.
- Add the >>> to each line in the Examples. It forces mkdocs to not squash examples into one line.
@Adakar Adakar force-pushed the adapt-docstrings-for-mkdocs branch from e4a50c1 to 032fa9e Compare July 5, 2023 12:18
@Adakar Adakar requested a review from pawtom July 5, 2023 12:26
@Adakar Adakar added the documentation Improvements or additions to documentation label Jul 10, 2023
@Adakar Adakar merged commit e44dee0 into main Jul 12, 2023
@Adakar Adakar deleted the adapt-docstrings-for-mkdocs branch July 20, 2023 08:14
Adakar added a commit that referenced this pull request Aug 22, 2023
* Adapt Examples sections to be multiline for mkdocs

Changes:
- Rename Example to Examples for all Example sections. This is required for mkdocs to display
multi-line examples correctly.
- Add the >>> to each line in the Examples. It forces mkdocs to not squash examples into one line.

* Fix imports in squishserver module

* Fix docstrings: multiline examples and Args

---------

Co-authored-by: Adakar <jakub.top@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants