Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rng related methods #135

Merged
merged 2 commits into from
Dec 22, 2022
Merged

Add rng related methods #135

merged 2 commits into from
Dec 22, 2022

Conversation

knshnb
Copy link
Contributor

@knshnb knshnb commented Dec 22, 2022

Add a public method to set rng seeds.
Also, I added the CMAwM._rng property for backward compatibility.

@knshnb
Copy link
Contributor Author

knshnb commented Dec 22, 2022

@c-bata Could you take a look when you have time?

c-bata
c-bata reviewed Dec 22, 2022
View reviewed changes
Copy link
Collaborator

@c-bata c-bata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add reseed_rng in SepCMA class?

@knshnb
Copy link
Contributor Author

knshnb commented Dec 22, 2022

Oh, sure, updated!

c-bata
c-bata approved these changes Dec 22, 2022
View reviewed changes
Copy link
Collaborator

@c-bata c-bata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@c-bata c-bata merged commit 25370a5 into CyberAgentAILab:main Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-bata c-bata c-bata approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knshnb @c-bata