refactor(spa): delete viewing methods on non l-values

Curve · Oct 13, 2024 · f34a784 · f34a784
1 parent 265855a
commit f34a784
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 4 deletions.
diff --git a/include/rohrkabel/spa/pod/object/object.hpp b/include/rohrkabel/spa/pod/object/object.hpp
@@ -36,7 +36,10 @@ namespace pipewire::spa
         pod_object &operator=(pod_object &&) noexcept;
 
       public:
-        [[nodiscard]] spa::pod pod() const;
+        [[nodiscard]] spa::pod pod() const &;
+        [[nodiscard]] spa::pod pod() const && = delete;
+
+      public:
         [[nodiscard]] spa::type type() const;
         [[nodiscard]] std::uint32_t id() const;
 

diff --git a/include/rohrkabel/spa/pod/prop.hpp b/include/rohrkabel/spa/pod/prop.hpp
@@ -32,7 +32,10 @@ namespace pipewire::spa
         pod_prop &operator=(pod_prop &&) noexcept;
 
       public:
-        [[nodiscard]] pod value() const;
+        [[nodiscard]] pod value() const &;
+        [[nodiscard]] pod value() const && = delete;
+
+      public:
         [[nodiscard]] std::uint32_t flags() const;
         [[nodiscard]] enum_value<prop> key() const;
 

diff --git a/src/spa/spa.pod.object.cpp b/src/spa/spa.pod.object.cpp
@@ -27,7 +27,7 @@ namespace pipewire::spa
         return *this;
     }
 
-    spa::pod pod_object::pod() const
+    spa::pod pod_object::pod() const &
     {
         return spa::pod::view(&m_impl->object->pod);
     }

diff --git a/src/spa/spa.pod.prop.cpp b/src/spa/spa.pod.prop.cpp
@@ -26,7 +26,7 @@ namespace pipewire::spa
         return *this;
     }
 
-    pod pod_prop::value() const
+    pod pod_prop::value() const &
     {
         return pod::view(&m_impl->prop->value);
     }