adds configurable timout feature #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added timeout to Proxy.conf * Http Client handles timeout * added TimeoutError to errors.rs
Codecov Report
@@ Coverage Diff @@
## main #62 +/- ##
=======================================
Coverage 55.35% 55.35%
=======================================
Files 4 4
Lines 336 336
Branches 94 94
=======================================
Hits 186 186
Misses 70 70
Partials 80 80 |
|
Since we are using one single number for different timeouts, I suggest we test properly to see if it works as intended. For example, fetching a large file may take a minute or two, that should not timeout if progress is being made. |
Taaseen-Ali
reviewed
Aug 30, 2021
bhaskarkishore
previously approved these changes
Sep 6, 2021
Taaseen-Ali
previously approved these changes
Sep 7, 2021
bhaskarkishore
dismissed stale reviews from Taaseen-Ali and themself
via
0f4cead
bhaskarkishore
approved these changes
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added timeout to Proxy.Conf, Http Client handles timeout via a new added dependency 'hyper-timeout' and and fetch handles std timeout error propagated by hyper-timeout to hyper , the inbuilt errors of hyper for timeout and its accompanying function is_timeout() don't work with hyper-timeout . closes #56.