Add support for passing arbitrary file descriptors to the log #32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the flexibility of how FFmpeg log output is handled in the
better_ffmpeg_progress.py
module. The main change allows the log destination to be either a file path or a file-like object, such assys.stdout
, making it easier to redirect FFmpeg logs for different use cases.FFmpeg log output handling improvements:
self._ffmpeg_log_file
in__init__
to support bothos.PathLike
objects and direct file-like objects, enabling the use of custom log destinations.run
method to check the type ofself._ffmpeg_log_file
and handle writing to either a file path or a file descriptor (e.g.,sys.stdout
). This ensures compatibility with various logging scenarios. [1] [2]