Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No-Jira - Improve Previews Workflows #932

Merged
merged 2 commits into from
Apr 30, 2024
Merged

No-Jira - Improve Previews Workflows #932

merged 2 commits into from
Apr 30, 2024

Conversation

wrandall22
Copy link
Contributor

@wrandall22 wrandall22 commented Apr 26, 2024 •
edited
Loading

Description

Remove extra step (this was done before but got lost in the rebase)

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@wrandall22 wrandall22 added the Preview Environment Add this label to create an Amplify Preview label Apr 26, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 26, 2024 •
edited
Loading

Bundle sizes [mpdx-react]

Compared against c427b08

No significant changes found

@github-actions GitHub Actions
Copy link

Preview branch generated at https://improve-previews.d3dytjb8adxkk5.amplifyapp.com

2 similar comments
@github-actions GitHub Actions
Copy link

Preview branch generated at https://improve-previews.d3dytjb8adxkk5.amplifyapp.com

@github-actions GitHub Actions
Copy link

Preview branch generated at https://improve-previews.d3dytjb8adxkk5.amplifyapp.com

@wrandall22 wrandall22 requested a review from canac April 29, 2024 13:58
@github-actions GitHub Actions
Copy link

Preview branch generated at https://improve-previews.d3dytjb8adxkk5.amplifyapp.com

canac
canac approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@canac canac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think the An error occurred (NotFoundException) when calling the GetBranch operation: Branch xxx not found. error I got was a fluke? Or are you working in addressing that in a different PR?

@wrandall22
Copy link
Contributor Author

It has been addressed in my fork of the GH action. You can watch that here if you'd like. I believe I got it all working now.

@wrandall22
Copy link
Contributor Author

One challenge I've seen is that if On Staging is on the PR already and Preview Environment is applied it didn't seem to trigger. I'm not sure why.

@wrandall22 wrandall22 added the On Staging Will be merged to the staging branch by Github Actions label Apr 29, 2024
@github-actions GitHub Actions
Copy link

Preview branch generated at https://improve-previews.d3dytjb8adxkk5.amplifyapp.com

@wrandall22 wrandall22 added On Staging Will be merged to the staging branch by Github Actions and removed On Staging Will be merged to the staging branch by Github Actions labels Apr 29, 2024
@github-actions GitHub Actions
Copy link

Preview branch generated at https://improve-previews.d3dytjb8adxkk5.amplifyapp.com

@wrandall22
Try only running this job when the actual label added is the preview …
ce583dc 
…environment label (not if any label includes this text). This should ensure we do not run it more than we need
@wrandall22 wrandall22 added On Staging Will be merged to the staging branch by Github Actions Preview Environment Add this label to create an Amplify Preview and removed On Staging Will be merged to the staging branch by Github Actions Preview Environment Add this label to create an Amplify Preview labels Apr 30, 2024
@github-actions GitHub Actions
Copy link

Preview branch generated at https://improve-previews.d3dytjb8adxkk5.amplifyapp.com

@wrandall22 wrandall22 merged commit 6370c51 into main Apr 30, 2024
22 checks passed
@wrandall22 wrandall22 deleted the improve-previews branch April 30, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canac canac canac approved these changes

Assignees
No one assigned
Labels
On Staging Will be merged to the staging branch by Github Actions Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wrandall22 @canac