HS-968801 - Fix note filter #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the typescript check is failing because the API changes aren't yet in production. |
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
wrandall22
force-pushed
the
HS-968801-fix-note-filter
branch
from
985d281
to
626bbb6
Compare
wrandall22
force-pushed
the
HS-968801-fix-note-filter
branch
from
8853604
to
611283c
Compare
dr-bizz
reviewed
Jul 19, 2023
dr-bizz
approved these changes
Jul 20, 2023
|
Does it work ok on the PGA report? |
Good catch. It's no longer producing an error, but it doesn't filter the contacts on |
|
Seems like a bigger issue. A few filters on PGA report don't work. I'm looking into fixing this on this PR. |
… fixing Search notes filters
dr-bizz
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I imagine this will need some more work, but it is what I could get figured out today.
Helpscout
The search notes filter is currently throwing errors, so Shelby made a fix to the API which changes the shape of the GraphQL query. I have tested this on the contacts page locally, both as a saved filter and not-saved filter. The changes to
FilterPanellines 640-642 were purely for the test's benefits, this code was not reached during my testing on the site. It makes me curious if there are some improper assumptions somewhere, or if there is another way to reach that code.