[MPDX-8230] Fix 14 month report export button doing nothing #1078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, only part of the button was a download link. Now, the entire button is a download link. The easiest way to accomplish this was to stop using the react-csv Link component and instead use the method that it uses internally to create the blob download URL.
|
Preview branch generated at https://8230-export-download-fail.d3dytjb8adxkk5.amplifyapp.com |
Bundle sizes [mpdx-react]Compared against bc5798e
|
|
This seems to solve it. |
wrandall22
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sometimes the fourteen month report export button was doing nothing. This is because only part of the button was a download link. Now, the entire button is a download link. The easiest way to accomplish this was to stop using the react-csv
Linkcomponent and instead use the method that it uses internally to create the blob download URL and add thathrefto theButtoncomponent.@wrandall22 If you have time, let me know if you can reproduce the bug after this fix.
MPDX-8230
Checklist: