Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MPDX-8221] Align 14 month reports with Angular #1065

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Conversation

canac
Copy link
Contributor

@canac canac commented Sep 13, 2024

Description

One major discrepancy I saw is that the 14 month reports were actually including 15 months. I adjusted the date range in the query to match Angular.

@wrandall22 Do you want to test again in preview that this fixes the discrepancies you were seeing? The numbers match on my account now, besides rounding differences (React is more accurate).

MPDX-8221 and MPDX-8228

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@canac canac added the Preview Environment Add this label to create an Amplify Preview label Sep 13, 2024
Copy link

Preview branch generated at https://8221-14-month-export.d3dytjb8adxkk5.amplifyapp.com

Copy link

github-actions bot commented Sep 13, 2024

Bundle sizes [mpdx-react]

Compared against 8b0cff9

No significant changes found

Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good. I'll let Bill review the UI and check the details match.

@wrandall22
Copy link
Contributor

This probably solves some issues, but not the ones I reported. The alignment UX is still off and the partner currency report is still showing USD instead of the foreign currency.

Screenshot 2024-09-16 at 9 53 41 AM Screenshot 2024-09-16 at 9 53 51 AM

@canac
Copy link
Contributor Author

canac commented Sep 16, 2024

@wrandall22 Which environment is that first screenshot from (local, staging, preview, prod)? I'm seeing different numbers in the report in local and preview. Also, which account list id are you using? Thanks.

@wrandall22
Copy link
Contributor

Both screenshots are from the preview environment with the Pedro Perez account list

@canac
Copy link
Contributor Author

canac commented Sep 16, 2024

@wrandall22 I think that some of the problems stem from the fact that the React 14 month reports only show one table instead of one table per currency. I'm working on a fix for that as part of https://jira.cru.org/browse/MPDX-8227. I also fixed the column alignment issue you pointed out. If the code in this PR looks good, I'll merge it but keep the Jira ticket open until we can verify that the upcoming fixes for MPDX-8227 fix the remaining inconsistencies you're seeing.

@canac canac requested a review from dr-bizz September 16, 2024 16:06
@wrandall22
Copy link
Contributor

Alignment looks good.

@canac canac merged commit 2e9aee8 into main Sep 16, 2024
17 of 18 checks passed
@canac canac deleted the 8221-14-month-export branch September 16, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants