-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MPDX-8221] Align 14 month reports with Angular #1065
Conversation
Preview branch generated at https://8221-14-month-export.d3dytjb8adxkk5.amplifyapp.com |
Bundle sizes [mpdx-react]Compared against 8b0cff9 No significant changes found |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good. I'll let Bill review the UI and check the details match.
@wrandall22 Which environment is that first screenshot from (local, staging, preview, prod)? I'm seeing different numbers in the report in local and preview. Also, which account list id are you using? Thanks. |
Both screenshots are from the preview environment with the Pedro Perez account list |
@wrandall22 I think that some of the problems stem from the fact that the React 14 month reports only show one table instead of one table per currency. I'm working on a fix for that as part of https://jira.cru.org/browse/MPDX-8227. I also fixed the column alignment issue you pointed out. If the code in this PR looks good, I'll merge it but keep the Jira ticket open until we can verify that the upcoming fixes for MPDX-8227 fix the remaining inconsistencies you're seeing. |
Alignment looks good. |
Description
One major discrepancy I saw is that the 14 month reports were actually including 15 months. I adjusted the date range in the query to match Angular.
@wrandall22 Do you want to test again in preview that this fixes the discrepancies you were seeing? The numbers match on my account now, besides rounding differences (React is more accurate).
MPDX-8221 and MPDX-8228
Checklist: