Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPDX-8187 + MPDX-8188 Add more warning messages when dragging contact to different columns. #1056

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

dr-bizz
Copy link
Contributor

@dr-bizz dr-bizz commented Sep 11, 2024

Description

My aim with this PR was top add clarity to the user's actions. Users have for sometime expressed how the received column is confusing and how when they drag a contact to received, it disappears and nothing happens.

With these changes, I plan to fix that by adding more warning messages, alerting the user that their desired outcome has not worked.

To make it easier, I have created a help function that I use in multiple places, so we only have to update the wording of these alerts in one place.

  1. A warning message when moving a contact from "Asked" or "Committed" to "Received"
  2. A warning message when moving a contact from "Received" to "Committed"
  3. A warning message when moving a contact from "Processed" to "Committed" or "Received"

https://jira.cru.org/browse/MPDX-8187
https://jira.cru.org/browse/MPDX-8188

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@dr-bizz dr-bizz requested a review from canac September 11, 2024 18:54
Copy link

Bundle sizes [mpdx-react]

Compared against 3cde16b

No significant changes found

Copy link
Contributor

@canac canac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a couple of ideas for improvements if you like them.

@dr-bizz dr-bizz merged commit 556abc4 into main Sep 12, 2024
18 checks passed
@dr-bizz dr-bizz deleted the MPDX-8187 branch September 12, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants