Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MPDX-8086] Add account creation instructions to login page #1034

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[MPDX-8086] Add account creation instructions to login page #1034

wants to merge 1 commit into from

Conversation

canac
Copy link
Contributor

@canac canac commented Sep 6, 2024 •
edited
Loading

Description

  • Add instructions for creating an Okta account to the login page. This text is hidden when the auth provider is API Oauth.
  • Refactor some login page tests for improved isolation.

MPDX-8086

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@canac canac added the Preview Environment Add this label to create an Amplify Preview label Sep 6, 2024
@canac canac requested a review from dr-bizz September 6, 2024 15:53
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 6, 2024

Preview branch generated at https://8086-create-account.d3dytjb8adxkk5.amplifyapp.com

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 6, 2024 •
edited
Loading

Bundle sizes [mpdx-react]

Compared against 191c853

No significant changes found

dr-bizz
dr-bizz approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This look great!! I think we sjould hold off pushing this out until the setup + tools are complete

@canac canac self-assigned this Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dr-bizz dr-bizz dr-bizz approved these changes

Assignees

@canac canac

Labels
Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@canac @dr-bizz