Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MPDX-8056 - Tools - Initial Page #1027

Merged
merged 7 commits into from
Sep 4, 2024
Merged

MPDX-8056 - Tools - Initial Page #1027

merged 7 commits into from
Sep 4, 2024

Conversation

wjames111
Copy link
Contributor

Description

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@wjames111 wjames111 added On Staging Will be merged to the staging branch by Github Actions Preview Environment Add this label to create an Amplify Preview labels Sep 4, 2024
@wjames111 wjames111 self-assigned this Sep 4, 2024
canac
canac approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@canac canac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! My only concern is some duplication in the tools list. It might be unavoidable; I wasn't sure.

src/components/Tool/Home/ToolsListHome.ts Show resolved Hide resolved
@caleballdrin caleballdrin added Preview Environment Add this label to create an Amplify Preview and removed Preview Environment Add this label to create an Amplify Preview labels Sep 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2024

Bundle sizes [mpdx-react]

Compared against e51dddf

No significant changes found

@wjames111 wjames111 added Preview Environment Add this label to create an Amplify Preview and removed Preview Environment Add this label to create an Amplify Preview labels Sep 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2024

Preview branch generated at https://MPDX-8056-initial-tools-page.d3dytjb8adxkk5.amplifyapp.com

caleballdrin
caleballdrin approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@caleballdrin caleballdrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@wjames111 wjames111 merged commit fdb6a3e into main Sep 4, 2024
18 of 20 checks passed
@wjames111 wjames111 deleted the MPDX-8056-initial-tools-page branch September 4, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canac canac canac approved these changes

@caleballdrin caleballdrin caleballdrin approved these changes

Assignees

@wjames111 wjames111

Labels
On Staging Will be merged to the staging branch by Github Actions Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wjames111 @canac @caleballdrin