Update translations #1026
Update translations #1026
Conversation
Bundle sizes [mpdx-react]Compared against c2b3d21
|
|
That's a good point. I will check |
src/lib/i18n.ts
Outdated
| @@ -10,7 +10,18 @@ i18next | |||
| .init({ | |||
| nsSeparator: false, | |||
| keySeparator: false, | |||
| fallbackLng: 'en', | |||
| // Since these languages have different translation folder names | |||
There was a problem hiding this comment.
This code doesn't look wrong, but I don't think it's necessary. Even without this configuration, if the user's language is fr-fr, i18next still seems to normalize the casing and requests fr-FR/translations.json. Have you checked that it is broken without this configuration?
This configuration still seems useful to keep though since it does more than just fix the casing: 'fr-ca': ['fr-CA', 'fr-FR', 'en'],
There was a problem hiding this comment.
I thought I did, but let me double check
There was a problem hiding this comment.
You are correct. I think I tested it without restarting my local, which affected it.
dr-bizz
force-pushed
the
update-translations
branch
from
6542401
to
8ffaeef
Compare
Yes it is, so the fallback isn't working, but once we work out OneSky it will work. |
Description
In this PR, I have run the following scripts,
yarn extract&yarn onesky:download, which have updated the translation files.I've also ran
yarn onesky uploadto update OneSky with our latest phrases.Checklist: