Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MPDX-8096] Add default account setup page #1021

Merged
merged 3 commits into from
Aug 30, 2024
Merged

[MPDX-8096] Add default account setup page #1021

merged 3 commits into from
Aug 30, 2024

Conversation

canac
Copy link
Contributor

@canac canac commented Aug 29, 2024

Description

  • Add default account setup page to let the user choose their default account list
  • If the user has only one account list, the server will set this account list to the default and redirect to the next step in the tour

MPDX-8096

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@canac canac added the Preview Environment Add this label to create an Amplify Preview label Aug 29, 2024
@canac canac requested a review from dr-bizz August 29, 2024 21:05
@github-actions GitHub Actions
Copy link

Preview branch generated at https://8096-setup-account-page.d3dytjb8adxkk5.amplifyapp.com

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 29, 2024 •
edited
Loading

Bundle sizes [mpdx-react]

Compared against 9d0f572

Route Size (gzipped) Diff
/setup/account 94.21 KB added

dr-bizz
dr-bizz reviewed Aug 30, 2024
View reviewed changes
Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some comments, but it looks good.]]]]]]]]]

pages/setup/account.page.tsx Outdated Show resolved Hide resolved
pages/setup/account.page.tsx Show resolved Hide resolved
pages/setup/account.page.tsx Show resolved Hide resolved
pages/setup/account.page.test.tsx Outdated Show resolved Hide resolved
dr-bizz
dr-bizz reviewed Aug 30, 2024
View reviewed changes
Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some comments, but it looks good.]]]]]]]]]

]]]]]]]]] - My cat sat on my keyboard

@canac canac requested a review from dr-bizz August 30, 2024 14:19
dr-bizz
dr-bizz approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@canac canac merged commit c09143f into main Aug 30, 2024
18 checks passed
@canac canac deleted the 8096-setup-account-page branch August 30, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dr-bizz dr-bizz dr-bizz approved these changes

Assignees
No one assigned
Labels
Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@canac @dr-bizz