Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading GitHub Actions Workflows Xcode Version #1463

Merged
merged 3 commits into from
May 16, 2023

Conversation

levieggertcru
Copy link
Collaborator

Upgrade to Mac OS 13 and Xcode 14.2.

env:
DEVELOPER_DIR: /Applications/Xcode_14.0.app/Contents/Developer
DEVELOPER_DIR: /Applications/Xcode_14.2.app/Contents/Developer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's kind of annoying that you have to specify the Xcode version like this. I did find a GHA action that supposedly will select the XCode version for you: https://github.com/marketplace/actions/setup-xcode-version

It might be a bit more readable that just a directory path being specified

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @frett. I will look into using Xcode select.

It appears I will have to put this PR on hold as mac-os 13 isn't available yet (actions/runner-images#6426)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frett @rachaelblue this is ready again for review.
GitHub Action workflows are set to run on macos-13 and use Xcode version 14.2

frett
frett previously approved these changes Jan 4, 2023
@levieggertcru levieggertcru requested a review from frett January 5, 2023 14:04
@frett frett marked this pull request as draft February 20, 2023 23:58
@levieggertcru levieggertcru removed the WIP label May 16, 2023
@levieggertcru levieggertcru marked this pull request as ready for review May 16, 2023 19:31
@levieggertcru levieggertcru merged commit bc174ad into develop May 16, 2023
@levieggertcru levieggertcru deleted the update-github-actions-xcode-version-to-14.2 branch May 16, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants