Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retry with backoff to all client operations #186

Merged
merged 3 commits into from
Jul 31, 2024

Conversation

dylan-bourque
Copy link
Collaborator

This PR adds a retry (with backoff + jitter) to all client operations to help with transient 502-Server Unavailable errors.

Additional changes:

  • Updated the Docker Compose test setup to use PostgreSQL v16 and v0.40.0 of the pg-semver extension (which includes a fix for incorrect errors when parsing pre-release tokens that start with a 0 but aren't numbers.
  • As an optimization, moved the retrieval of the latest module version for the perseus list-modules CLI command from the client to the server.
  • Updated the client dial logic to automatically use H2C for non-TLS client connections (so that users don't need to know that they have to)

injected retry with backoff and jitter for all client operations
extended ListModules server handler to include the latest version in the result
@dylan-bourque dylan-bourque requested a review from a team July 29, 2024 02:12
@dylan-bourque dylan-bourque merged commit 6416dd2 into main Jul 31, 2024
3 checks passed
@dylan-bourque dylan-bourque deleted the feat/add-retry-for-client-ops branch July 31, 2024 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants