Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ BUG ] Support module imports #1056

Closed
jshcodes opened this issue Oct 21, 2023 · 0 comments · Fixed by #1062
Closed

[ BUG ] Support module imports #1056

jshcodes opened this issue Oct 21, 2023 · 0 comments · Fixed by #1062
Assignees
Labels
bug 🐛 Something isn't working SDK usage General SDK usage issues and questions

Comments

@jshcodes
Copy link
Member

Describe the bug
The default pattern for leveraging FalconPy within your project involves installing the Python package from the Python Package Index (PyPI). For users that wish to include the contents of the src folder (from the repo) within their projects, they will receive a ModuleNotFound error if they do not have the simplejson package installed locally to the user.

To Reproduce
Synchronize the FalconPy repo, then copy the src/falconpy folder into the root of your project. When you try to run your project, you will receive a ModuleNotFound error.

Expected behavior
Import is successful, and the developer is able to leverage the FalconPy library as normal.

Environment (please complete the following information):

  • OS: All Supported
  • Python: All Supported
  • FalconPy: 1.2.5 - 1.3.2

Additional context
Thanks to @tsullivan06 for identifying and reporting this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working SDK usage General SDK usage issues and questions
Projects
None yet
1 participant