fix: run missing edge test for real without EDGE_PATH hack

CrowdStrike · Oct 5, 2022 · 3e8efa7 · 3e8efa7
1 parent 18c8d30
commit 3e8efa7
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 10 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -79,6 +79,11 @@ jobs:
       with:
         node-version: ${{ matrix.node }}
 
+    - run: sudo rm $(which microsoft-edge)
+      if: matrix.os == 'ubuntu-latest'
+    - run: rm '/Applications/Microsoft Edge.app/Contents/MacOS/Microsoft Edge'
+      if: matrix.os == 'macos-latest'
+
     - run: yarn install --frozen-lockfile
     - run: yarn test --config .mocharc.no-edge.js
 

diff --git a/src/index.js b/src/index.js
@@ -67,12 +67,6 @@ async function getDetectedDriverVersion() {
   let version;
 
   let browserCmd = (() => {
-    let edgePathOverride = process.env.EDGE_PATH;
-
-    if (edgePathOverride) {
-      return edgePathOverride;
-    }
-
     switch (platform) {
       case 'linux': return 'microsoft-edge';
       case 'darwin': return '/Applications/Microsoft Edge.app/Contents/MacOS/Microsoft Edge';

diff --git a/test/helpers/edge.js b/test/helpers/edge.js
@@ -1,9 +1,7 @@
 'use strict';
 
 const oldVersion = '102.0.1245.33';
-const missingPath = 'missing-edge';
 
 module.exports = {
   oldVersion,
-  missingPath,
 };
diff --git a/test/no-edge/install-msedgedriver-test.js b/test/no-edge/install-msedgedriver-test.js
@@ -6,7 +6,6 @@ const execa = require('execa');
 const fs = require('fs').promises;
 const { getDriverPath } = require('../../src');
 const path = require('path');
-const { missingPath } = require('../helpers/edge');
 
 const installerPath = require.resolve('../../bin/install-msedgedriver');
 const driverPath = getDriverPath();
@@ -26,7 +25,6 @@ describe(path.basename(installerPath), function() {
     let ps = await execa.node(installerPath, [], {
       env: {
         DETECT_EDGEDRIVER_VERSION: 'true',
-        EDGE_PATH: missingPath,
       },
     });