Fix hashtag search performing account search as well (mastodon#13758)

CrossGate-Pawoo · Jan 14, 2022 · 12fc07c · 12fc07c
1 parent 59b0603
commit 12fc07c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/app/services/search_service.rb b/app/services/search_service.rb
@@ -94,7 +94,7 @@ def full_text_searchable?
   end
 
   def account_searchable?
-    account_search? && !(@query.include?('@') && @query.include?(' '))
+    account_search? && !(@query.start_with?('#') || (@query.include?('@') && @query.include?(' ')))
   end
 
   def hashtag_searchable?

diff --git a/spec/services/search_service_spec.rb b/spec/services/search_service_spec.rb
@@ -91,6 +91,14 @@
           expect(Tag).not_to have_received(:search_for)
           expect(results).to eq empty_results
         end
+        it 'does not include account when starts with # character' do
+          query = '#tag'
+          allow(AccountSearchService).to receive(:new)
+
+          results = subject.call(query, nil, 10)
+          expect(AccountSearchService).to_not have_received(:new)
+          expect(results).to eq empty_results
+        end
       end
     end
   end