Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/saxon for model preprocessing #9

Merged
merged 8 commits into from
Oct 25, 2024

Conversation

willem-xbreeze
Copy link
Contributor

Re-implement saxon parser for model preprocessing

Copy link
Contributor

@harmen-xb harmen-xb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change, I expected more code changes needed :).

I added some comments on the commit.

Willem Otten and others added 3 commits October 20, 2024 21:10
… message.

Override GetLocalizedMessage in ModelPreprocessorException to format the exception message to what we want.
Updated two tests one errors.
Copy link
Contributor

@harmen-xb harmen-xb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is ok.

@harmen-xb harmen-xb merged commit bbdeca9 into main Oct 25, 2024
2 checks passed
@harmen-xb harmen-xb deleted the feature/SaxonForModelPreprocessing branch October 25, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants