Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to be more readable #1

Draft
wants to merge 61 commits into
base: master
Choose a base branch
from
Draft

Refactor to be more readable #1

wants to merge 61 commits into from

Conversation

Crinibus
Copy link
Owner

Also cache response from API

@Crinibus Crinibus marked this pull request as draft October 16, 2022 18:37
Crinibus added 20 commits October 17, 2022 08:07
@Crinibus
Create tvguide.py
2466bf5
@Crinibus
Fix
bbe78b1
@Crinibus
Use requests_cache to cache requests
78e6e2a
@Crinibus
Use filesystem as backend to requests_cache
9cdbcd4
@Crinibus
Update Filemanager to have root_path and defaults_ini_path as properties
f6fee07
@Crinibus
Add type hint in class Channel
2b60744
@Crinibus
Update class TvGuide
afb2928 
- Add properties
- Update method parse_arguments
- Add methods parse_api_data, print_programs and get_channels
@Crinibus
Create main_v2.py to test with
870d8a8
@Crinibus
Fix method print_programs in class TvGuide
1c71b12
@Crinibus
Update values in CHANNEL_NUMBER_INDEX to replce "-" with spaces and d…
e237891 
…elete method Format.channel_name and delete line in README about channel name
@Crinibus
Delete duplicate print statements in class Channel
8072b1e
@Crinibus
Delete method add_program in class Channel and just add programs in m…
adacf08 
…ethod format_program_info
@Crinibus
Add type hints to properties in classes Channel and Program
ba006bd
@Crinibus
Update tvguide.py
60c13eb
@Crinibus
Update TvGuide.print_programs - Get all channels if show_all_channels…
3cfcf1e 
… is true else only the input channels
@Crinibus
Update TvGuide.print_programs - show all programs if show_all_program…
082d2af 
…s is true
@Crinibus
Rename method format_program_info to _parse_channel_info in class Cha…
92058f4 
…nnel
@Crinibus
Update format.py
e584a9e
@Crinibus
Rename method format_info to _format_info in class Program
9486e05
@Crinibus
Fix type hints
4e63846
Crinibus added 30 commits October 18, 2022 07:06
@Crinibus
Simplify method is_running in class Program
cf65530
@Crinibus
Add static method read_defaults_config_file to class ConfigManager
dfc5294
@Crinibus
Add static method get_timezone to class ConfigManager
c577462
@Crinibus
Move class Channel under class Program in tv.py
401cbf6
@Crinibus
Delete argument --default-space-seperator
8f82920 
And everything that used that argument
@Crinibus
Update class Channel - create "_get..." methods to simplify "print_..…
4cb5d66 
…." methods
@Crinibus
Simplify method "is_running_at" in class Program
aaf36ed
@Crinibus
Update class TvGuide - add properties to keep track of what to print …
97d37a6 
…and add if-statements in methods "parse_arguments" and "print_programs"
@Crinibus
Use cache when reading config file
e116880
@Crinibus
Update README - requires python 3.9+
e0c0212
@Crinibus
Reorder imports and replace relative imports with absolute imports
c99e5b3
@Crinibus
Update LICENCE to 2022
b620e84
@Crinibus
Fix import
67e41d3
@Crinibus
Update tv.py
35d8b2f
@Crinibus
Add print when currently running program is found
669a894
@Crinibus
Split a line to two lines
410eff9
@Crinibus
Format with black
7de08ef
@Crinibus
Add config files for flake8 and black
960bffb
@Crinibus
Format with black
e50d968
@Crinibus
Update Chrome version in REQUEST_HEADER
b5f3ca2
@Crinibus
Add print when using default channels
6b7f0d4 
Print the default channels
@Crinibus
Change prints before showing the programs
11dac39 
Add what the user has inputted, e.g. categories, times and search terms
@Crinibus
Fix print statements in main.py - delete end=""
8b8ab24
@Crinibus
Add try catch around main function call
834be88
@Crinibus
Delete main.py
2c4f8c0
@Crinibus
Delete method format_data in ApiManager class
4d24a1a
@Crinibus
Rename main_v2.py to main.py
839b3bd
@Crinibus
Add type hints to all instance variables in TvGuide class
bcbefcc
@Crinibus
Rename instance variable "channels" to "all_channels" in TvGuide class
1ec9630
@Crinibus
Simplify documentation of arguments in README
b226984
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Crinibus