Second Approach to Fix #5420 #8907
Conversation
Allmoz
force-pushed
the
contraption_container_reloaded
branch
4 times, most recently
from
34af35a to
8064502
Compare
There was a problem hiding this comment.
This does look like a better solution to me (assuming it works), simply because there's no hardcoding every case, which will be more compatible with other mods and is less prone to breaking when a new feature is released.
Performance-wise this might perform slightly worse /w the level creation (but tbf that's only once per disassembly)
But kind reminder that the decision on what's better isn't mine to take (:
| @@ -1144,6 +1144,8 @@ public void addBlocksToWorld(Level world, StructureTransform transform) { | |||
|
|
|||
| translateMultiblockControllers(transform); | |||
|
|
|||
| SingleBlockServerLevel popChamber = new SingleBlockServerLevel((ServerLevel) world); | |||
There was a problem hiding this comment.
Is world actually always a serverlevel here?
There was a problem hiding this comment.
Good point, i was assuming so since you can't add entities (drop items) if not. I can probably change it also to create the level only on the first fail
Allmoz
force-pushed
the
contraption_container_reloaded
branch
from
8064502 to
88fc285
Compare
|
thanks for the remainder, but i'm taking you down to the rabbit hole nonetheless :P (I really appreciate your help). Made the changes, now it will only create the level wrapper the first time a block "fails" to be placed and only if it's a server level. I did kept the sound event for both cases since the overridden destroy I did in the wrapped level is silent (no event is called there). |
This is a second approach to solve #5420 (first one is #8774). In this case, blocks are actually loaded on a wrapped servel level (that can contain only 1 block) to be able to use .onRemove on them. This should be a more general solution, but i don't know if is less performant. @VoidLeech is this better?