-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tariq work #308
Tariq work #308
Conversation
…ariq work 1/3/2025"
# Conflicts: # app/src/main/res/values-ru/strings.xml # build.gradle
…ariq work 1/3/2025"
…ariq work 1/3/2025"
…ariq work 1/3/2025"
# Conflicts: # .github/workflows/ci.yml # .github/workflows/windows.yml # app/build.gradle # app/src/main/java/rocks/poopjournal/todont/Adapters/AvoidedLogAdapter.java # app/src/main/java/rocks/poopjournal/todont/Adapters/DoneLogAdapter.java # app/src/main/java/rocks/poopjournal/todont/Adapters/HabitsAdapter.java # app/src/main/java/rocks/poopjournal/todont/Adapters/HabitsLogAdapter.java # app/src/main/java/rocks/poopjournal/todont/DatabaseManager.java # app/src/main/java/rocks/poopjournal/todont/DatabaseUtils.java # app/src/main/java/rocks/poopjournal/todont/Db_Controller.java # app/src/main/java/rocks/poopjournal/todont/Settings.java # app/src/main/res/values-he/strings.xml # app/src/main/res/values-ru/strings.xml # build.gradle # gradle/wrapper/gradle-wrapper.properties
…ariq work 1/3/2025" Again
@@ -23,7 +23,7 @@ | |||
- name: "🧪 Code coverage" | |||
run: ./gradlew test | |||
- name: "📤 Upload code coverage" | |||
uses: codecov/codecov-action@v5 | |||
uses: codecov/codecov-action@v4 |
Check warning
Code scanning / Semgrep (reported by Codacy)
An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Warning
@@ -23,7 +23,7 @@ | |||
- name: "🧪 Code coverage" | |||
run: ./gradlew jacocoTestReport | |||
- name: "📤 Upload code coverage" | |||
uses: codecov/codecov-action@v5 | |||
uses: codecov/codecov-action@v4 |
Check warning
Code scanning / Semgrep (reported by Codacy)
An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Warning
@@ -0,0 +1,5 @@ | |||
package androidx.databinding.library.baseAdapters; |
Check warning
Code scanning / Pmd (reported by Codacy)
Package name contains upper case characters Warning generated
private static final SparseIntArray INTERNAL_LAYOUT_ID_LOOKUP = new SparseIntArray(2); | ||
|
||
static { | ||
INTERNAL_LAYOUT_ID_LOOKUP.put(rocks.poopjournal.todont.R.layout.activity_main, LAYOUT_ACTIVITYMAIN); |
Check warning
Code scanning / Pmd (reported by Codacy)
Unnecessary use of fully qualified name 'rocks.poopjournal.todont.R.layout.activity_main' due to existing same package import 'rocks.poopjournal.todont.*' Warning generated
|
||
static { | ||
INTERNAL_LAYOUT_ID_LOOKUP.put(rocks.poopjournal.todont.R.layout.activity_main, LAYOUT_ACTIVITYMAIN); | ||
INTERNAL_LAYOUT_ID_LOOKUP.put(rocks.poopjournal.todont.R.layout.fragment_daily, LAYOUT_FRAGMENTDAILY); |
Check warning
Code scanning / Pmd (reported by Codacy)
Unnecessary use of fully qualified name 'rocks.poopjournal.todont.R.layout.fragment_daily' due to existing same package import 'rocks.poopjournal.todont.*' Warning generated
if(localizedLayoutId > 0) { | ||
final Object tag = view.getTag(); | ||
if(tag == null) { | ||
throw new RuntimeException("view must have a tag"); |
Check notice
Code scanning / Pmd (reported by Codacy)
Avoid throwing raw exception types. Note generated
if(tag == null) { | ||
throw new RuntimeException("view must have a tag"); | ||
} | ||
switch(localizedLayoutId) { |
Check notice
Code scanning / Pmd (reported by Codacy)
Switch statements should be exhaustive, add a default case (or missing enum branches) Note generated
} | ||
// views | ||
@NonNull | ||
private final android.widget.FrameLayout mboundView0; |
Check notice
Code scanning / Pmd (reported by Codacy)
Perhaps 'mboundView0' could be replaced by a local variable. Note generated
} | ||
|
||
@Override | ||
protected boolean onFieldChange(int localFieldId, Object object, int fieldId) { |
Check notice
Code scanning / Pmd (reported by Codacy)
The method 'onFieldChange(int, Object, int)' has an NPath complexity of 2147483647, current threshold is 200 Note generated
|
||
@Override | ||
protected boolean onFieldChange(int localFieldId, Object object, int fieldId) { | ||
switch (localFieldId) { |
Check notice
Code scanning / Pmd (reported by Codacy)
Switch statements should be exhaustive, add a default case (or missing enum branches) Note generated
|
||
@Override | ||
protected void executeBindings() { | ||
long dirtyFlags = 0; |
Check notice
Code scanning / Pmd (reported by Codacy)
Avoid unused local variables such as 'dirtyFlags'. Note generated
// Listener Stub Implementations | ||
// callback impls | ||
// dirty flag | ||
private long mDirtyFlags = 0xffffffffffffffffL; |
Check warning
Code scanning / Pmd (reported by Codacy)
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. Warning generated
Thank you so much. This is awesome! 😍 |
Tariq work done "1/3/2025"