Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine install documentation for Perlmutter and Frontier #717

Merged
merged 4 commits into from
Sep 23, 2024

Conversation

ashao
Copy link
Member

@ashao ashao commented Sep 20, 2024

After discussing with admins at OLCF, miniforge is the preferred solution for creating virtual environments on Frontier. The instructions for installing SmartSim have been updated accordingly. Additionally, perlmutter did not have a step for compiling the SmartRedis libraries. This has been rectified to bring the two systems to parity.

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.80%. Comparing base (d7d979e) to head (347efe1).
Report is 7 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #717      +/-   ##
===========================================
- Coverage    83.91%   81.80%   -2.11%     
===========================================
  Files           83       84       +1     
  Lines         6284     7075     +791     
===========================================
+ Hits          5273     5788     +515     
- Misses        1011     1287     +276     

see 47 files with indirect coverage changes

Copy link
Member

@MattToast MattToast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment, but otherwise these updated instructions seem to work on Frontier! I'll hold off on giving the full approval since I cannot test on Perlmutter :(

doc/installation_instructions/platform/frontier.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@AlyssaCote AlyssaCote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These instruction work on Frontier and Perlmutter! LGTM!

@ashao ashao merged commit 2f68c08 into CrayLabs:develop Sep 23, 2024
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants