Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More easily discoverable dependencies #635

Merged
merged 11 commits into from
Jul 18, 2024
Merged

Conversation

ashao
Copy link
Member

@ashao ashao commented Jul 17, 2024

setup.py used to define dependencies in a way that was not amenable to code scanning tools. Direct dependencies now appear directly in the setup call and the definition of the SmartRedis version has been removed. Additionally, the code scanning tool was failing to detect some of the dependencies due to the existence of the requirements-doc.txt file. These requirements are now listed in the docs extra.

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.38%. Comparing base (96b37c2) to head (7d54163).

❗ There is a different number of reports uploaded between BASE (96b37c2) and HEAD (7d54163). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (96b37c2) HEAD (7d54163)
3 1
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #635      +/-   ##
===========================================
- Coverage    69.68%   63.38%   -6.30%     
===========================================
  Files           83       83              
  Lines         6208     6208              
===========================================
- Hits          4326     3935     -391     
- Misses        1882     2273     +391     

see 46 files with indirect coverage changes

setup.py Outdated
"pyzmq>=25.1.2",
"pygithub>=2.3.0",
"numpy<2",
"smartredis>=0.5,<0.6",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation nitpick!

Copy link
Contributor

@ankona ankona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ashao ashao merged commit 723544e into CrayLabs:develop Jul 18, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants