Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove broken redis documentation links #627

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

ankona
Copy link
Contributor

@ankona ankona commented Jul 1, 2024

This PR will remove a broken link to oss.redis.com that is breaking the documentation build

Copy link
Member

@MattToast MattToast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for keeping the docs up to date!!

Copy link
Member

@ashao ashao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that

Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.17%. Comparing base (8423eb4) to head (5f7062a).
Report is 17 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop     #627       +/-   ##
============================================
+ Coverage    63.41%   75.17%   +11.75%     
============================================
  Files           83       83               
  Lines         6208     6208               
============================================
+ Hits          3937     4667      +730     
+ Misses        2271     1541      -730     
Files with missing lines Coverage Δ
smartsim/database/orchestrator.py 76.77% <ø> (+14.23%) ⬆️

... and 47 files with indirect coverage changes

@ankona ankona merged commit 96b37c2 into CrayLabs:develop Jul 2, 2024
36 checks passed
@ankona ankona deleted the oss-redis-url-fix branch September 25, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants