Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support for SGE #610

Merged
merged 11 commits into from
Jun 17, 2024
Merged

Implement support for SGE #610

merged 11 commits into from
Jun 17, 2024

Conversation

ashao
Copy link
Member

@ashao ashao commented Jun 7, 2024

SGE shares some similarities to PBS/Torque-like launchers, but the differences are significant enough to warrant their own separate implementations. Notably, SGE has a qacct utility (similar to SLURM's sacct) to query for the historical record of a job. Additionally, unique amongst the launchers, SGE does not allow a way for a user to specify the number of nodes needed and requires the user to select a admin-configured parallel environment profile (e.g. mpi or smp).

The changes add a new SGE launcher and SGEQsubBatchSettings to enable support for SmartSim applications on SGE machines.

SGE shares some similarities to PBS/Torque-like launchers, but the
differences are significant enough to warrant their own
separate implementations. Notably, SGE has a qacct utility (similar
to SLURM's sacct) to query for the historical record of a job.
Additionally, unique amongst the launchers, SGE does not allow a
way for a user to specify the number of nodes needed and requires
the user to select a admin-configured parallel environment profile
(e.g. mpi or smp).

The changes add a new SGE launcher and SGEQsubBatchSettings to
enable support for SmartSim applications on SGE machines.
@ashao ashao requested a review from al-rigazzi June 7, 2024 22:06
Copy link
Collaborator

@al-rigazzi al-rigazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woah, a ton of great stuff! Some nits here and there, but otherwise looks good

smartsim/_core/launcher/sge/sgeParser.py Outdated Show resolved Hide resolved
smartsim/_core/launcher/sge/sgeParser.py Outdated Show resolved Hide resolved
smartsim/_core/launcher/sge/sgeParser.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@al-rigazzi al-rigazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! Love the care to details and the amount of SGE-specific settings and methods you implemented. I just have a few small requests and then it's ready to go!

smartsim/_core/launcher/sge/sgeLauncher.py Outdated Show resolved Hide resolved
smartsim/_core/launcher/sge/sgeLauncher.py Outdated Show resolved Hide resolved
smartsim/_core/launcher/sge/sgeParser.py Outdated Show resolved Hide resolved
smartsim/_core/launcher/sge/sgeParser.py Outdated Show resolved Hide resolved
smartsim/_core/launcher/sge/sgeParser.py Outdated Show resolved Hide resolved
smartsim/_core/launcher/sge/sgeParser.py Outdated Show resolved Hide resolved
smartsim/_core/launcher/step/mpiStep.py Show resolved Hide resolved
smartsim/_core/launcher/stepInfo.py Outdated Show resolved Hide resolved
smartsim/_core/launcher/stepInfo.py Outdated Show resolved Hide resolved
doc/changelog.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@al-rigazzi al-rigazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for all the hard work on this one!

@ashao ashao merged commit 0956399 into CrayLabs:develop Jun 17, 2024
34 checks passed
@ashao ashao added type: feature Issues that include feature request or feature idea area: settings Issues related to Batch or Run settings area: launcher Issues related to any of the launchers within SmartSim repo: smartsim Issues related to SmartSim infrastructure library labels Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: launcher Issues related to any of the launchers within SmartSim area: settings Issues related to Batch or Run settings repo: smartsim Issues related to SmartSim infrastructure library type: feature Issues that include feature request or feature idea
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants