Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build error caused by use of deprecated pkg_resources #598

Merged
merged 7 commits into from
May 23, 2024
Merged

Fix build error caused by use of deprecated pkg_resources #598

merged 7 commits into from
May 23, 2024

Conversation

ankona
Copy link
Contributor

@ankona ankona commented May 22, 2024 •
edited
Loading

Fixes a build error encountered after the latest update of setuptools.

Additional Included Changes

  • Fixed non-working links causing documentation build to fail validation

@ankona ankona requested review from MattToast and mellis13 May 22, 2024 20:03
@ankona ankona changed the title Replace use of vendored packaging Fix build error caused by use of deprecated pkg_resources May 22, 2024
@ankona ankona added the bug: major A major bug label May 22, 2024
@ankona ankona self-assigned this May 22, 2024
@ankona ankona marked this pull request as ready for review May 22, 2024 20:05
@ankona ankona added area: build Issues related to builds, makefiles, installs, etc repo: smartsim Issues related to SmartSim infrastructure library labels May 22, 2024
MattToast
MattToast requested changes May 22, 2024
View reviewed changes
Copy link
Member

@MattToast MattToast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran into one small problem when installing without the ml or dev optional dependencies, but otherwise LGTM!

setup.py Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented May 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.63%. Comparing base (fbcc46a) to head (179c9b0).
Report is 12 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #598      +/-   ##
===========================================
- Coverage    60.75%   60.63%   -0.13%     
===========================================
  Files           78       78              
  Lines         5935     6000      +65     
===========================================
+ Hits          3606     3638      +32     
- Misses        2329     2362      +33

see 8 files with indirect coverage changes

@ankona ankona requested a review from MattToast May 22, 2024 22:44
MattToast
MattToast approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@MattToast MattToast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending tests!! Thanks for tracking this down!

@ankona ankona merged commit 54755ad into CrayLabs:develop May 23, 2024
36 checks passed
@ankona ankona deleted the packaging-fix branch June 3, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattToast MattToast MattToast approved these changes

@mellis13 mellis13 Awaiting requested review from mellis13

Assignees

@ankona ankona

Labels
area: build Issues related to builds, makefiles, installs, etc bug: major A major bug repo: smartsim Issues related to SmartSim infrastructure library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ankona @MattToast